docs(components): react-page scope comment says ObjectGrid, not the unregistered ObjectTable by os-zhuang · Pull Request #2938 · objectstack-ai/objectui

os-zhuang · 2026-07-28T17:21:04Z

Problem

The kind:'react' page renderer's header comment in
react-page.tsx
advertised two identifiers that do not exist. An author following the
comment hit a wall either way:

Comment said	What actually happens
`<ObjectTable>` (line 22)	`ReferenceError` — surfaced as the red "React page error" panel
`<Block type="object-table" />` (line 26)	"Unknown component type"

Why

buildComponentScope (react-page.tsx:50-86) builds the injected scope by
PascalCasing each public, non-container tag from the curated
PUBLIC_BLOCKS contract. That list
(public-blocks.ts:26-66)
carries object-grid — never object-table — so the real injected
identifier has always been ObjectGrid.

object-grid is genuinely registered, and without isContainer, so it
survives the container filter and lands in the scope:

plugin-grid/src/index.tsx:55 — ComponentRegistry.register('object-grid', ObjectGridRenderer, {...})

Verification that `object-table` has no registration

grep -rn "object-table" packages apps docs returns only:

this doc comment (now fixed),
packages/components/dist/...d.ts — stale build output, regenerates,
packages/sdui-parser compiler fixtures (__tests__/*, verify.ts) — these
build their own inline synthetic manifests and a fake in-test
ComponentRegistry.register, and never touch the real product registry.

So nothing in the product registers object-table.

Change

Comment-only — two lines, no behavior change, no changeset (not a feature).

- *   - the PUBLIC data blocks — `<ObjectTable>`, `<ObjectForm>`, charts, metrics…
+ *   - the PUBLIC data blocks — `<ObjectGrid>`, `<ObjectForm>`, charts, metrics…
...
- *   - `Block`                — escape hatch: `<Block type="object-table" .../>`.
+ *   - `Block`                — escape hatch: `<Block type="object-grid" .../>`.

🤖 Generated with Claude Code

…nregistered ObjectTable The `kind:'react'` page header comment advertised two identifiers that do not exist, so an author following it hit a wall either way: - `<ObjectTable>` -> ReferenceError, surfaced as the red "React page error" panel. `buildComponentScope` PascalCases each public non-container tag from the curated PUBLIC_BLOCKS contract, which carries `object-grid` (registered in plugin-grid) and no `object-table` at all, so the real injected identifier has always been `ObjectGrid`. - `<Block type="object-table" />` -> "Unknown component type", since nothing registers that type anywhere in the product. `object-table` survives only in sdui-parser's synthetic compiler fixtures, which build their own inline manifests and never touch the real registry. Comment-only; no behavior change. Co-Authored-By: Claude <noreply@anthropic.com>

vercel · 2026-07-28T17:21:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 28, 2026 5:21pm

github-actions · 2026-07-28T17:24:26Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.9 KB	350 KB
Entry file	`index-B1LNlMWm.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.20KB	2.97KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.25KB	1.01KB
auth (org-roles.js)	6.72KB	2.85KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	450.13KB	97.92KB
core (index.js)	2.16KB	0.78KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	127.78KB	32.15KB
fields (index.js)	220.07KB	53.90KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	6.84KB	2.42KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	57.26KB	16.24KB
plugin-chatbot (index.js)	179.93KB	42.67KB
plugin-dashboard (index.js)	109.60KB	28.33KB
plugin-designer (index.js)	210.56KB	42.56KB
plugin-detail (index.js)	216.77KB	53.01KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	103.51KB	25.12KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	179.35KB	46.97KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	98.55KB	23.28KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.07KB	9.81KB
plugin-timeline (index.js)	25.03KB	7.11KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.68KB	20.85KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.00KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.86KB	0.91KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.04KB	1.93KB
types (system-fields.js)	2.39KB	1.17KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

… doc comments (#2947) Follow-up to #2938. `ObjectTable` is not a typo but a historical artifact: the component was renamed to `ObjectGrid` long ago (see the "ObjectTable: Auto-generates tables from ObjectQL object schemas" entries still recorded in the package CHANGELOGs), and some prose never followed. #2938 fixed the one occurrence that actually bit authors — the `kind:'react'` page scope comment, where the prose *is* the API documentation for a runtime-derived scope. These two are lower-stakes descriptive prose on type definitions, cleaned up so the dead name stops surviving in live code: - field-types.ts — the module doc for the field type system. - objectql.ts — `ObjectViewSchema`. Factually correct as well as mechanical: ObjectView renders an `object-grid` (plugin-view/src/ObjectView.tsx:858). `ObjectTable` now appears only in the package CHANGELOGs (immutable history), gitignored `dist/` output, and sdui-parser's synthetic compiler fixtures. Comment-only; no behavior change. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>

github-actions Bot added the package: components label Jul 28, 2026

os-zhuang merged commit 059f7ba into main Jul 28, 2026
16 checks passed

os-zhuang deleted the fix/react-page-doc-objectgrid branch July 28, 2026 17:27

os-zhuang mentioned this pull request Jul 29, 2026

docs(types): finish the ObjectTable -> ObjectGrid rename in two stale doc comments #2947

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs(components): react-page scope comment says ObjectGrid, not the unregistered ObjectTable - #2938

docs(components): react-page scope comment says ObjectGrid, not the unregistered ObjectTable#2938
os-zhuang merged 1 commit into
mainfrom
fix/react-page-doc-objectgrid

os-zhuang commented Jul 28, 2026

Uh oh!

vercel Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 28, 2026

Problem

Why

Verification that object-table has no registration

Change

Uh oh!

vercel Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Verification that `object-table` has no registration